This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Add support for Moodle Course Completion Webhooks#4
Draft
ATechAdventurer wants to merge 9 commits intomainfrom
Draft
Add support for Moodle Course Completion Webhooks#4ATechAdventurer wants to merge 9 commits intomainfrom
ATechAdventurer wants to merge 9 commits intomainfrom
Conversation
ATechAdventurer
changed the title
Member
Author
|
The only thing that remains is a way to easily define course_id => group_id. I don't think the source of truth for this map should be stored here and maybe inside Moodle itself |
jveski
reviewed
Sep 17, 2023
| log.Printf("user %s completed moodle course %s", user.Email, body.CourseID) | ||
| } | ||
|
|
||
| err = kc.AddUserToGroup(r.Context(), user.ID, "6e413212-c1d8-4bc9-abb3-51944ca35327") |
Member
There was a problem hiding this comment.
Consider exposing the group ID as an env var in case it ever changes
| } | ||
|
|
||
| user := &User{ | ||
| ID: gocloak.PString(kcuser.ID), |
Member
There was a problem hiding this comment.
Not necessary in this PR, but it would be nice to move the gocloak.User -> User conversion logic into a helper function to avoid duplication.
Co-authored-by: Jordan Olshevski <jveski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.